kwild: write version to log file too (#1022)

* kwild: write version to log file too * elide trailing "+" if no Build.RevisionShort (from git)
kwilteam · Sep 25, 2024 · 4c84ae8 · 4c84ae8
1 parent b35de9d
commit 4c84ae8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/cmd/kwild/server/server.go b/cmd/kwild/server/server.go
@@ -57,6 +57,8 @@ func New(ctx context.Context, cfg *config.KwildConfig, genesisCfg *chain.Genesis
 	}
 	logger = *logger.Named("kwild")
 
+	logger.Infof("version %s commit %s", version.KwilVersion, version.Build.RevisionShort)
+
 	closers := &closeFuncs{
 		closers: []func() error{}, // logger.Close is not in here; do it in a defer in Start
 		logger:  logger,

diff --git a/internal/version/version.go b/internal/version/version.go
@@ -28,7 +28,7 @@ var (
 func init() {
 	if KwilVersion == "" { // not set via ldflags
 		KwilVersion = kwilVersion
-		if Build != nil {
+		if Build != nil && Build.RevisionShort != "" {
 			// Append VCS revision and workspace dirty flag.
 			sep := "+" // start build metadata
 			if strings.Contains(KwilVersion, "+") {