Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommitSignatures support for verifying the correctness of the committ… #1196

Merged
merged 5 commits into from
Jan 6, 2025

Conversation

charithabandi
Copy link
Contributor

…ed block

@charithabandi charithabandi marked this pull request as draft January 3, 2025 23:42
@charithabandi charithabandi linked an issue Jan 6, 2025 that may be closed by this pull request
@charithabandi charithabandi marked this pull request as ready for review January 6, 2025 15:02
@charithabandi charithabandi force-pushed the commit-info branch 2 times, most recently from a779aef to 66972b0 Compare January 6, 2025 16:01
Copy link
Member

@jchappelow jchappelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks great. Just probably need some length and error checks in the stream response readers.

node/block.go Outdated Show resolved Hide resolved
node/block.go Outdated Show resolved Hide resolved
node/types/interfaces.go Show resolved Hide resolved
@charithabandi charithabandi merged commit 9286759 into kwilteam:main Jan 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Complete Block Header
2 participants