Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add image at the cursor location and not at the end #12

Merged
merged 2 commits into from
May 23, 2022
Merged

fix: add image at the cursor location and not at the end #12

merged 2 commits into from
May 23, 2022

Conversation

saikatmitra91
Copy link
Contributor

@saikatmitra91 saikatmitra91 commented May 22, 2022 •
edited
Loading

Fixes #11

PR Changes:

  • added all features for the editor
  • fix for adding image at the cursor location and not at the end
  • added divider for specific command groups

@saikatmitra91
Copy link
Contributor Author

@kwinyyyc can you please look at this PR at the earliest. Am planning to integrate this into our application.

@kwinyyyc
Copy link
Owner

kwinyyyc commented May 23, 2022 •
edited
Loading

Thanks, it looks good to me.

I have found out there is a typo on the package name, so I renamed it and released it here https://www.npmjs.com/package/strapi-plugin-wysiwyg-react-md-editor

@kwinyyyc kwinyyyc merged commit 379e0bc into kwinyyyc:master May 23, 2022
@saikatmitra91
Copy link
Contributor Author

Okay ! Thanks @kwinyyyc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On Uploading image from media gallery, the image always gets appended at the end
2 participants
@saikatmitra91 @kwinyyyc