Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(strapi): upgraded strapi support for v5 #39

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

johnmgrant
Copy link
Contributor

@johnmgrant johnmgrant commented Oct 5, 2024

Closes #38

* Updated [project structure for v5 support](https://docs.strapi.io/dev-docs/plugins/development/plugin-structure)
* Updated admin interface to utilize new design system and deprecate helper plugin
@kwinyyyc
Copy link
Owner

kwinyyyc commented Oct 5, 2024

@johnmgrant thanks a lot for preparing the PR, I haven't followed along for the strapi upgrade for a while. I have published your changes as a beta version, but the markdown editor doesn't show up, anything I missed there?

@johnmgrant
Copy link
Contributor Author

Hey @kwinyyyc ,

No problem at all. I only completed the path restructuring and resolved the build errors. I'll take a look at it today since I need this for a project I'm working on 😬

@johnmgrant
Copy link
Contributor Author

johnmgrant commented Oct 5, 2024

@kwinyyyc

@johnmgrant thanks a lot for preparing the PR, I haven't followed along for the strapi upgrade for a while. I have published your changes as a beta version, but the markdown editor doesn't show up, anything I missed there?

Seems to be working for me in Strapi 5.0.2. Note that Strapi v4 plugins are not compatible with Strapi v5 due to the shift to using the Plugin SDK package. The plugin migration guide can be found here.

Screenshot 2024-10-05 at 9 59 50 AM Screenshot 2024-10-05 at 10 00 03 AM

Here's my setup:

...
"dependencies": {
    "@strapi/admin": "^5.0.2",
    "@strapi/core": "^5.0.2",
    "@strapi/data-transfer": "^5.0.2",
    "@strapi/design-system": "2.0.0-rc.11",
    "@strapi/icons": "2.0.0-rc.11",
    "@strapi/plugin-users-permissions": "^5.0.2",
    "@strapi/sdk-plugin": "^5.2.6",
    "@strapi/strapi": "^5.0.2",
    "@strapi/typescript-utils": "^5.0.2",
    "@strapi/utils": "^5.0.2",
    "lodash": "^4.17.21",
    "mysql2": "^3.11.3",
    "pm2": "^5.4.2",
    "react": "^18.0.0",
    "react-dom": "^18.0.0",
    "react-router-dom": "^6.0.0",
    "strapi-plugin-transformer": "git+https://github.com/johnmgrant/strapi-plugin-transformer.git#dev/strapi-v5-migration",
    "strapi-plugin-wysiwyg-react-md-editor": "git+https://github.com/johnmgrant/strapi-plugin-wysiwyg-react-md-editor#dev/strapi-v5-migration",
    "styled-components": "^6.0.0",
    "yup": "^1.4.0"
  }
...

@kwinyyyc
Copy link
Owner

kwinyyyc commented Oct 6, 2024

@johnmgrant This is the official Markdown editor strapi introduced, you can use it without installing the plugin
Thanks for the information, I will have a look

@kwinyyyc kwinyyyc merged commit b9198cb into kwinyyyc:master Oct 6, 2024
1 check passed
@kwinyyyc
Copy link
Owner

kwinyyyc commented Oct 6, 2024

@johnmgrant FYI your PR is merged and a new version is published https://www.npmjs.com/package/strapi-plugin-wysiwyg-react-md-editor/v/5.0.2 while some features is still broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support on Strapi v5
2 participants