fix medias popup + improved assets to markdown serialization #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordielachance
force-pushed
the
master
branch
from
287b869 to
b3e29ad
Compare
gordielachance
changed the title
+fixed cursor bug.
kwinyyyc
requested changes
Oct 19, 2024
There was a problem hiding this comment.
Thanks for the PR, the media library can pop up as expected but there. is error when inserting the image to the markdown content
Uncaught TypeError: Cannot read properties of null (reading 'slice')
at handleChangeAssets (strapi-plugin-wysiwyg-react-md-editor_strapi-admin.js?v=f53dbeb2:101544:28)
| if (!isOpen) { | ||
| return null; | ||
| } | ||
|
|
||
| return ( | ||
| <MediaLibraryDialog |
There was a problem hiding this comment.
There is a typing issue on MediaLibraryDialog causing strapi build failed
'MediaLibraryDialog' cannot be used as a JSX component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.