Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've parsed all properties from kafka configuration here https://github.com/edenhill/librdkafka/blob/master/CONFIGURATION.md into PHP classes with constants and proper description.
So for example
Type: string
Type: integer
Will be
So I have classes
GlobalConfig.php
GlobalConsumer.php
GlobalProducer.php
Topic.php
TopicConsumer.php
TopicProducer.php
I created an issue php-enqueue/enqueue-dev#464 in
php-enqueue
repo, but they pointed me atphp-rdkafka
extension, but I think, this is better place to put those constants.I'm not sure about
namespace
and dir structure.What do you think?