Introduce MVVM #147
Draft
Introduce MVVM #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `App` struct serves as the model in the MVC pattern. The proposed MVVM refactor will continue using it as the primary Model. Rename `App` to `Model` to better reflect it's purpose. Signed-off-by: Ivin Joel Abraham <ivinjabraham@gmail.com>
The `View` is a crucial part of MVVM that will handle the UI. Rename the struct from `CurrentScreen`, which conveys logic, to simply `View` that will reflect it's purpose in the architecture. Signed-off-by: Ivin Joel Abraham <ivinjabraham@gmail.com>
ivinjabraham
force-pushed
the
refactor/introduce-mvvm
branch
from
60a720b to
491da19
Compare
The MVVM refactor will require a trait for viewmodels to establish a reliable interface. Introduce a basic implementation of the trait with no usage. Signed-off-by: Ivin Joel Abraham <ivinjabraham@gmail.com>
ivinjabraham
force-pushed
the
refactor/introduce-mvvm
branch
from
f0fc8a9 to
d24496f
Compare
To use as a key in a hashmap, a type must implement `Eq` and `Hash`. Additionally, `Copy` is required as well to be used in the .entry() method of Hashmap. Derive `Eq`, `Copy` and `Hash` on View to use it as a key in Hashmaps. Signed-off-by: Ivin Joel Abraham <ivinjabraham@gmail.com>
ivinjabraham
force-pushed
the
refactor/introduce-mvvm
branch
from
d24496f to
4b10584
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address #139. I cannot foresee all the necessary steps at the moment but I will change this body when I can see the plan taking a more concrete form. Ideally, I will be able to integrate it without causing regressions i.e have the new architecture work alongside the old. But it is unclear how to go about that at the moment.
My local version of
clippy(v0.1.88) seems to have added a new check and is now throwing errors for string interpolation syntax across the codebase. I haven't fixed them in this PR since it seems logically out of place. Though I think someone should raise an issue if they can confirm that it's not just on my machine.