Handle scalars for HOME Keldeo & Meltan; use coded AbilityType for LGPE simulated cards #4446
Conversation
|
About the Ribbon Issue: Hence, the simplest solution may be to implement proper ribbon handling—along with transfer logic to other games—at least for the Souvenir Ribbon, in both the WB7 and PB7 classes. Other ribbons wouldn't be strictly necessary, as there’s no way to obtain them in a PB7 file. This approach would ensure that we have a legal PB7 containing the correct ribbon data, and also allows us to check ribbon legality in Gen8+ games, even if the original data comes from a WB7. I can eventually look into it in the coming days, but it'll probably be later than your planned eta timeline. |
The AbilityType for LGPE wondercards was hardcoded to 3, to ensure that the ability of generated entities was picked randomly (Any12). From what I’ve seen, the Meltan distributed via the HOME gift always has Ability 1. To make sure the first ability slot is always chosen during generation, the program needs to properly read the AbilityType from the wondercard. I’ve set the wondercard to contain AbilityType 0, so that 'OnlyFirst' is selected.
The handling for height, weight, and scale follows the same approach as the other classes.
Meltan is particularly tricky. The mystery gift stores the Souvenir Ribbon in the core data of the PH3. However, the WB7 and PB7 classes do not currently handle ribbons. It might be possible to utilize unused space within the WB7 and PB7 data, but the code flow would need to be reworked. I’m not sure how we should proceed to properly account for that ribbon.