Skip to content

Add more node tests #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 16, 2022
Merged

Add more node tests #52

merged 2 commits into from
Mar 16, 2022
+115 −13

Conversation

kylebarron
Copy link
Owner

@kylebarron kylebarron commented Mar 16, 2022 •
edited
Loading

  • Add a testArrowTablesEqual to try and accurately test that two JS Arrow tables are the same, first by calling t.deepEquals on their schema, and then by calling t.deepEquals on each data vector.
  • Test that reading each Parquet file written from Python matches the Arrow IPC file written from Python.
  • Test that the tables match at the beginning and the end of the round trip from Arrow -> Parquet -> Arrow

@kylebarron kylebarron merged commit 0ec19cb into main Mar 16, 2022
@kylebarron kylebarron deleted the kyle/update-tests branch March 16, 2022 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kylebarron