How to make jupyter automatically close the stata session

[Gritbadger]

Hi，thank you for writing stata_kernel, which is very convenient to use. I can use python's powerful data functions and stata's powerful statistical functions at the same time.

But there is a problem, that is, whenever I use jupyterlab to create a new stata notebook, execute the stata command, and finally close the stata notebook, but jupyter will not automatically close the stata process, I have to enter the Windows task window every time, and manually close the stata process, which makes me Very convenient. Is there a way to fix this?

[kylebarron]

Looks like this is supposed to be handled through do_shutdown. We do call self.stata.shutdown()

stata_kernel/stata_kernel/kernel.py

Line 340 in b7cd972

self.stata.shutdown()

which tries to run exit, clear in Stata:

stata_kernel/stata_kernel/stata_session.py

Lines 577 to 578 in b7cd972

	if config.get('execution_mode') == 'automation':
	self.automate('DoCommandAsync', 'exit, clear')

Not sure off the top of my head why that wouldn't work in Windows. Maybe config.get('execution_mode') isn't set properly on Windows. We could switch that to if is_windows() or config.get('execution_mode') == 'automation':