feat: Better ANSI support detection. (#43)

kylef · Dec 15, 2016 · e45aa71 · e45aa71
1 parent 2779764
commit e45aa71
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Commander Changelog
 
+### Bug Fixes
+
+- Better detection of ANSI support in output tty.
+  [#43](https://github.com/kylef/Commander/issues/43)
+
 ## 0.6.0
 
 ### Enhancements

diff --git a/Sources/Error.swift b/Sources/Error.swift
@@ -12,7 +12,9 @@ protocol ANSIConvertible : Error, CustomStringConvertible {
 
 extension ANSIConvertible {
   func print() {
-    if isatty(fileno(stderr)) != 0 {
+    // Check if we are in any term env and the output is a tty.
+    if let termType = getenv("TERM"), String(cString: termType).lowercased() != "dumb" &&
+      isatty(fileno(stdout)) != 0 {
       fputs("\(ansiDescription)\n", stderr)
     } else {
       fputs("\(description)\n", stderr)