Make ping() Public #134
Merged
Make ping() Public #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-added _ping to prevent having to move to a major version. Some users may have used/relied on this pseudo-private method and I do not want to break anyones implementations. We could deprecate it but its not really worth the effort since `_ping` is just an alias to the public `ping` method. Also updated tests and API docs to reflect the re-adding of _ping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancements / Modifications
._ping()private method to a public method calledping()to allow users to perform health checks. (thanks to @hduprat-qare for feat: makepingmethod public #133)