Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme to inform users they can use their Emma Credentials #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sastrakhan
Copy link

Users can utilize their Emma credentials instead of the private/public
key to access the API if the keys are unavailable

Users can utilize their Emma credentials instead of the private/public
key to access the API if the keys are unavailable
@kylegregory
Copy link
Owner

Hey @sastrakhan

Thanks for the PR. Where did you find this information? I'm not seeing that ability in the documentation: http://api.myemma.com/

@sastrakhan
Copy link
Author

Hey @kylegregory. It's not listed in the documentation. I had a client requirement to use the username/password authentication and I was worried your authentication wouldn't support it but then I saw you were using the HttpBasicAuthentication object so I tried it and it worked.

I thought I'd suggest it as an addendum to the readme to inform developers before they tried an unnecessary path of making an alternative EmmaAPI constructor when it's not necessary ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants