-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
garbage chars in status output on Windows #3
Comments
Hmm, I'm not sure -- it looks like some type of encoding issue, but I can't seem to reproduce it in my DOS environment. Given that I can't make it happen, I'm at a loss as to how to correct it. I will continue to look around, but I don't notice anything obvious at the moment. |
I don't know how relevant is it after 2 years, but the problem is that the P.S. Thanks for this nifty tool :) |
@RaMMicHaeL have you experienced this issue? I cannot reproduce the output problem in Windows, Linux or OSX. I am reluctant to make any changes without being able to verify the effectiveness. Having said that, I see there are some white-space issues (mix of tabs/spaces) -- I'll correct that. P.S. you are welcome, I hope you find it useful. |
@kylehuff, yes, I can reproduce it on my system. To fix it, just replace this:
With:
The code is not ideal, either, as having a zip file name longer than 30 characters will cause a buffer overrun. |
I seem to remember there was a reason for the char array size of 30 -- but since I can't find a legit reason, I changed the initialization of to be the size of dst_len. Please let me know if this resolves the issue, as I still cannot reproduce it (for me, the ideone link did not exhibit the issue described) |
That's not correct - char dst[dst_len]; With: char dst[dst_len+4+1];
Unfortunately, I don't know how to correctly compile the project with Visual Studio.
Look at the code (exactly what you've had) and the output below. You would expect it to print |
dst never actually gets the suffix. I just pushed a commit that initializes dst as the entire length of argv[1], and fills it as needed. |
Yeah, I was in the middle of taking a test when I made those changes. thanks for the pull request, I'll merge it. |
Great. |
Closing with the release of v0.2 -- kylehuff/buildcrx/releases/tag/v0.2 |
I can confirm that it works as expected now. Thanks! |
Hi Kyle - any idea why I get those three garbage characters after 'WebCapture' in the output copy/pasted below?
The resulting .crx seems to be accepted by Chrome without complaint.
Oddly, I seem to only see these when running buildcrx from the 'dos box', not when it runs from my .bat file.
c:\build\DotTwain\firefox-plugin\build\bin\WebCapture\MinSizeRel>buildcrx WebCapture.zip WebCapture.pem
Bulding a test ZIP file
strcat: WebCapture▄■(.crx
Extension name is WebCapture.zip, and will be WebCapture▄■(.crx
-----BEGIN PUBLIC KEY-----
MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQC73IWLPvyPexoIWwmKV+Yz2Qti
XfQ0AFKjzyYy7DlWTtsfO6MJXwqt5JpCRSuSFK3/6KaG14k4uJrOe8H1tRLNQnok
AZBdzviF+s8Og8Y6qbA0PDxqjofqIQrQp8uSi6EtSxVqoz04nXyI9OChboGCvRaI
Wh5rcbVoxZtKdxNhaQIDAQAB
-----END PUBLIC KEY-----
Content Size: 1417742 (1384.51 KB)
RSA Keysize: 128, RSA (DER) size: 162
Signature Size: 128
Saved extension to WebCapture▄■(.crx
The text was updated successfully, but these errors were encountered: