Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Add Status entry initialization in binding and instance controller #5

Merged

Conversation

mszostok
Copy link

@mszostok mszostok commented Mar 8, 2019

This PR is a

  • Feature Implementation
  • Bug Fix
  • Documentation

What this PR does / why we need it:

Previously the status entry was initialized in api-server in PrepareForCreate function. Right now we cannot do that in webhook handler, so as a temporary workaround we need to move this logic to the controller reconcile function.

Which issue(s) this PR fixes

Final merge blocked by: https://github.com/kyma-incubator/service-catalog/pull/7/files

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
ggwpez Oliver Tale-Yazdi
Copy link

@adamwalach adamwalach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I tested the ServiceInstance and it properly sets the status field to:

  status:
    asyncOpInProgress: false
    conditions: []
    deprovisionStatus: NotRequired
    observedGeneration: 0
    orphanMitigationInProgress: false
    provisionStatus: ""
    reconciledGeneration: 0

@mszostok mszostok merged commit 4e06987 into kyma-incubator:crd-prod-impl Mar 17, 2019
@mszostok mszostok deleted the status-init-in-ctrl-v1 branch March 17, 2019 23:29
mszostok added a commit that referenced this pull request May 17, 2019

Verified

This commit was signed with the committer’s verified signature.
ggwpez Oliver Tale-Yazdi
mszostok added a commit that referenced this pull request Aug 14, 2019

Verified

This commit was signed with the committer’s verified signature.
mszostok added a commit that referenced this pull request Sep 11, 2019

Verified

This commit was signed with the committer’s verified signature.
jasiu001 pushed a commit to jasiu001/service-catalog that referenced this pull request Sep 23, 2019

Verified

This commit was signed with the committer’s verified signature.
… (CRDs) solution (kubernetes-retired#2630)

* Add basic validation to crds

* Add webhook skeleton, remove api-server from chart, add webhoook server in chart, move PrepareForCreate login into webhook handler (kyma-incubator#2)

* Add webhook skeleton, remove api-server from chart, add webhoook server in chart, move PrepareForCreate login into webhook handler

* Add logger and GVK matcher

* Add test coverage for webhook (kyma-incubator#6)

* Add Status entry initialization in binding and instance controller (kyma-incubator#5)

* Change fs to label selector (kyma-incubator#9)

* Fix removing finalizer after switching to CRD /status sub-resource (kyma-incubator#8)

* Add tests to webhooks (kyma-incubator#11)

* Replace changevalidator with webhook (kyma-incubator#14)

* Replace default service plan with webhook (kyma-incubator#10)

* Add tests to webhooks - fix

* Rewrite defaultServicePlan feature to webhook

* Replace plugins by webhook (kyma-incubator#16)

* Replace ServiceBinding plugin by webhook

* Replace Broker plugins by webhook

* Adjust webhooks to multi validation handlers

* Service Catalog going towards to CRDs (kyma-incubator#18)

* Migrate registry/strategy Updates to webhooks (kyma-incubator#17)

* Use Update instead of updateReference method (kyma-incubator#19)

* Replace tableconvertor with APC (kyma-incubator#20)

* Fix svcat tests after the rebase with the upstream master branch

* Pre delete jobs - remove CRD after delete helm release (kyma-incubator#21)

* Apply fixes after executing `make verify`

* Create docs about webhook implementation (kyma-incubator#24)

* Change the securePort for the webhook server because colidates with old api-server

* Change import paths to kubernetes-sigs, and rebase with master

* Apply fixes after rebase

Fixes:
* makefile targets,
* instance deprovision operation
* entries under additionalPrinterColumns in crds.yaml
* unit tests after rebase

* Update documentation (kyma-incubator#40)

* Update docs

* Fix vendor after rebase with k8s 1.15 bump

* Apply changes after review

- remove the contrib/hack/crd folder
- remove reference to Kyma project
- rebase with current master
- restore the image in chart
- extract CRDs defintion to dedicated folder
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants