remove httpClient interface

kyma-project · Feb 27, 2024 · 9e50d00 · 9e50d00
1 parent 19c1d6a
commit 9e50d00
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/internal/btp/client.go b/internal/btp/client.go
@@ -12,7 +12,7 @@ import (
 
 type LocalClient struct {
 	credentials *CISCredentials
-	cis         httpClientInterface
+	cis         *httpClient
 }
 
 func NewLocalClient(credentials *CISCredentials, token *XSUAAToken) *LocalClient {
@@ -32,13 +32,6 @@ func (t *oauthTransport) RoundTrip(r *http.Request) (*http.Response, error) {
 	return http.DefaultTransport.RoundTrip(r)
 }
 
-type httpClientInterface interface {
-	Get(string, requestOptions) (*http.Response, error)
-	Put(string, requestOptions) (*http.Response, error)
-	Post(string, requestOptions) (*http.Response, error)
-	Patch(string, requestOptions) (*http.Response, error)
-}
-
 type cisError struct {
 	Code          int    `json:"code"`
 	Message       string `json:"message"`
@@ -60,7 +53,7 @@ type httpClient struct {
 	client *http.Client
 }
 
-func newHttpClient(token *XSUAAToken) httpClientInterface {
+func newHttpClient(token *XSUAAToken) *httpClient {
 	return &httpClient{
 		client: &http.Client{
 			Transport: &oauthTransport{

diff --git a/internal/btp/provision_test.go b/internal/btp/provision_test.go
@@ -35,7 +35,7 @@ func fixProvisionHandler(t *testing.T) func(http.ResponseWriter, *http.Request)
 }
 
 func fixProvisionErrorHandler(t *testing.T) func(http.ResponseWriter, *http.Request) {
-	return func(w http.ResponseWriter, r *http.Request) {
+	return func(w http.ResponseWriter, _ *http.Request) {
 		data := cisErrorResponse{
 			Error: cisError{
 				Message: "error",