Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding customStateCheck using the Create Module command #1729

Closed
1 of 2 tasks
nesmabadr opened this issue Aug 11, 2023 · 3 comments · Fixed by #1764 or #1767
Closed
1 of 2 tasks

Support adding customStateCheck using the Create Module command #1729

nesmabadr opened this issue Aug 11, 2023 · 3 comments · Fixed by #1764 or #1767
Assignees

Comments

@nesmabadr
Copy link
Contributor

nesmabadr commented Aug 11, 2023

Description:

Since the lifecycle-manager now supports the module customStateCheck (kyma-project/lifecycle-manager#784), the CLI Create Module command should also support adding the customStateCheck field to the ModuleTemplate.

The docu on the custom state check is here

Acceptance Criteria:

  • Create Module command supports adding the customStateCheck field
  • There is an optional config file section for setting up the custom state check and the mappings
@LeelaChacha
Copy link
Contributor

blocked by #1752

@jeremyharisch
Copy link
Contributor

#1729 implementation works fine, but not uses the config file. It was implemented introducing new flags.

Needs to be changed:

  • Remove flags
  • Use config file instead

@jeremyharisch jeremyharisch reopened this Sep 12, 2023
@LeelaChacha
Copy link
Contributor

LeelaChacha commented Sep 12, 2023

#1729 implements the optional config file settingshere
@jeremyharisch @lindnerby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants