Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Deprecate kyma-cli v2 #2095

Merged
merged 4 commits into from
May 20, 2024
Merged

chore: Deprecate kyma-cli v2 #2095

merged 4 commits into from
May 20, 2024

Conversation

pPrecel
Copy link
Contributor

@pPrecel pPrecel commented May 16, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • add a deprecation note at the beginning of the main README.md file
  • add adeprecation note at the beginning of the kyma-cli main.go file

Related issue(s)

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2024
@kyma-bot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 16, 2024
@pPrecel pPrecel changed the title draft chore: deprecate kyma-cli v2 May 16, 2024
@pPrecel pPrecel changed the title chore: deprecate kyma-cli v2 Chore: Deprecate kyma-cli v2 May 16, 2024
@pPrecel pPrecel changed the title Chore: Deprecate kyma-cli v2 chore: Deprecate kyma-cli v2 May 16, 2024
@pPrecel pPrecel marked this pull request as ready for review May 16, 2024 11:27
@pPrecel pPrecel requested review from a team as code owners May 16, 2024 11:27
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2024
pPrecel
pPrecel commented May 16, 2024
View reviewed changes
README.md
@@ -2,6 +2,10 @@

# Kyma CLI

> [!WARNING]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's based on this article

@pPrecel pPrecel added area/cli Related to all activities around CLI kind/chore Categorizes issue or PR as related to a chore. labels May 17, 2024
kwiatekus
kwiatekus reviewed May 17, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
cmd/main.go Outdated Show resolved Hide resolved
@pPrecel @kwiatekus
Apply suggestions from code review
bc5118c 
Co-authored-by: Krzysztof Kwiatosz <krzysztof.kwiatosz@sap.com>
kwiatekus
kwiatekus previously approved these changes May 17, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 17, 2024
grego952
grego952 reviewed May 20, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@pPrecel @grego952
Update README.md
f77d9e3 
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label May 20, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 20, 2024
@kyma-bot kyma-bot merged commit 47cc8bf into kyma-project:main May 20, 2024
13 checks passed
pPrecel added a commit to pPrecel/cli that referenced this pull request May 20, 2024
@pPrecel @kwiatekus @grego952
chore: Deprecate kyma-cli v2 (kyma-project#2095)
f9399c3 
* draft

* update warning

* Apply suggestions from code review

Co-authored-by: Krzysztof Kwiatosz <krzysztof.kwiatosz@sap.com>

* Update README.md

Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>

---------

Co-authored-by: Krzysztof Kwiatosz <krzysztof.kwiatosz@sap.com>
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
@pPrecel pPrecel mentioned this pull request May 20, 2024
Merged
kyma-bot pushed a commit that referenced this pull request May 20, 2024
@pPrecel @kwiatekus @grego952
chore: Deprecate kyma-cli v2 (#2095) (#2096)
b444c7b 
* draft

* update warning

* Apply suggestions from code review



* Update README.md



---------

Co-authored-by: Krzysztof Kwiatosz <krzysztof.kwiatosz@sap.com>
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grego952 grego952 grego952 approved these changes

@kwiatekus kwiatekus kwiatekus left review comments

Assignees

@kwiatekus kwiatekus

@grego952 grego952

Labels
area/cli Related to all activities around CLI cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pPrecel @kyma-bot @kwiatekus @grego952