add HEALTHY column to modules list #2272
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
do-not-merge/work-in-progress
kyma-bot
added
size/XL
kyma-bot
removed
the
do-not-merge/work-in-progress
anoipm
reviewed
Dec 9, 2024
| @@ -87,7 +100,114 @@ func List(ctx context.Context, client kyma.Interface) (ModulesList, error) { | |||
| return modulesList, nil | |||
| } | |||
|
|
|||
| func getInstallDetails(kyma *kyma.Kyma, releaseMetas kyma.ModuleReleaseMetaList, moduleName string) ModuleInstallDetails { | |||
| func getModuleDeploymentHealth(ctx context.Context, client kube.Client, moduleTemplate kyma.ModuleTemplate, kymaCR *kyma.Kyma) (Healthy, error) { | |||
There was a problem hiding this comment.
Did you think about refactoring this method? It is now very complex (15 ifs inside) and hard to understand.
| return HealthyUnknown, nil | ||
| } | ||
|
|
||
| func getResourceState(ctx context.Context, client kube.Client, apiVersion, kind, namespace, name string) (string, error) { |
There was a problem hiding this comment.
The same as before. IMO this method is too complex and is hard to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
kyma alpha module listcommand with headerstate#2264