Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Sync) IpRange SKR reconciliation #47

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

tmilos77
Copy link
Contributor

Description

Changes proposed in this pull request:

  • added update status for the SKR IpRange
  • added SKR IpRange Reconciler
  • refactored composed.NewStateFactory(client, eventRecorder, scheme) into composed.NewStateFactory(stateCluster)

Related issue(s)

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2024
Copy link
Contributor

@ravi-shankar-sap ravi-shankar-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 18, 2024
@kyma-bot kyma-bot merged commit cd55d14 into kyma-project:main Jan 18, 2024
4 checks passed
@tmilos77 tmilos77 deleted the aws-nfs-volume branch January 22, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants