Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP Nfs Reconciliation #50

Merged
merged 3 commits into from
Jan 22, 2024
Merged

GCP Nfs Reconciliation #50

merged 3 commits into from
Jan 22, 2024

Conversation

ravi-shankar-sap
Copy link
Contributor

Description

Added GCPOptions to NfsInstance Spec
Added Hosts attribute to NfsInstance Status
Added action handlers for GCP NfsInstance Reconcilers.

Related issue(s)
NA

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 20, 2024
tmilos77
tmilos77 previously approved these changes Jan 22, 2024
Copy link
Contributor

@tmilos77 tmilos77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 just do make that will do go fmt ./... and format the code properly and the build will pass

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 22, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 22, 2024
@kyma-bot kyma-bot merged commit 2978f73 into kyma-project:main Jan 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants