Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GcpRedisInstance): make redisVersion upgradable #902

Merged
merged 6 commits into from
Dec 23, 2024

Conversation

dushanpantic
Copy link
Contributor

@dushanpantic dushanpantic commented Dec 18, 2024

Description

Changes proposed in this pull request:

  • .spec.redisVersion in GcpRedisInstance is now mutable. It is to be used to upgrade Redis Version. Allowed upgrades are:
    • REDIS_6_X to REDIS_7_0
    • REDIS_6_X to REDIS_7_2
    • REDIS_7_0 to REDIS_7_2

Related issue(s)
#916

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Dec 18, 2024
@dushanpantic dushanpantic force-pushed the upgrade-redis-instance branch from 9460a20 to fec039f Compare December 23, 2024 10:09
@dushanpantic dushanpantic marked this pull request as ready for review December 23, 2024 10:51
@dushanpantic dushanpantic requested review from a team as code owners December 23, 2024 10:51
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 23, 2024
@dushanpantic dushanpantic changed the title feat(GcpRedisInstance): make redis upgradable feat(GcpRedisInstance): make redisVersion upgradable Dec 23, 2024
@dushanpantic dushanpantic enabled auto-merge (squash) December 23, 2024 11:07
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 23, 2024
Copy link
Contributor

@ijovovic ijovovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dushanpantic dushanpantic merged commit c9fad48 into kyma-project:main Dec 23, 2024
19 of 22 checks passed
@dushanpantic dushanpantic deleted the upgrade-redis-instance branch December 23, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants