Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation of the 3rd party payload #236

Merged
merged 11 commits into from
Dec 27, 2024
Merged

Validation of the 3rd party payload #236

merged 11 commits into from
Dec 27, 2024
+140 −13

Conversation

mvshao
Copy link
Contributor

@mvshao mvshao commented Dec 17, 2024

Description

Changes proposed in this pull request:

  • verify if the runtimeID, that comes from external service Compass is in the correct UUID format
  • validate the URL of the token to the Compass Connector to ensure it points to the SAP domain
  • perform a sanity check on the Token itself

Related issue(s)
#54

@mvshao mvshao requested a review from a team as a code owner December 17, 2024 07:39
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 17, 2024
@mvshao mvshao added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed cla: yes Indicates the PR's author has signed the CLA. labels Dec 17, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Dec 17, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 24, 2024
@mvshao mvshao removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 27, 2024
koala7659
koala7659 reviewed Dec 27, 2024
View reviewed changes
controllers/configurator_test.go Show resolved Hide resolved
controllers/configurator_test.go Show resolved Hide resolved
controllers/configurator_test.go Outdated Show resolved Hide resolved
mvshao and others added 2 commits December 27, 2024 09:15
@mvshao @koala7659
Apply suggestions from code review
97af2d8 
Co-authored-by: Przemyslaw Golicz <przemyslaw.golicz@sap.com>
@mvshao
Change the approach
576c752
koala7659
koala7659 approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 27, 2024
@kyma-bot kyma-bot merged commit 1541828 into kyma-project:main Dec 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koala7659 koala7659 koala7659 approved these changes

Assignees

@koala7659 koala7659

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvshao @koala7659 @kyma-bot