compass-id-for-migration
#32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kyma-bot
added
the
size/L
VOID404
force-pushed
the
feature/#10-compass-id-for-migration
branch
from
71c88be to
e638bb6
Compare
4 tasks
mvshao
reviewed
Oct 13, 2023
| // KubeconfigKey is the name of the key in the secret storing cluster credentials. | ||
| // The secret is created by KEB: https://github.com/kyma-project/control-plane/blob/main/components/kyma-environment-broker/internal/process/steps/lifecycle_manager_kubeconfig.go | ||
| KubeconfigKey = "config" | ||
| ) | ||
|
|
||
| //+kubebuilder:rbac:groups=apiextensions.k8s.io,resources=customresourcedefinitions,verbs=get;list;watch | ||
| //+kubebuilder:rbac:groups=operator.kyma-project.io,resources=kymas,verbs=get;list;watch | ||
| //+kubebuilder:rbac:groups=operator.kyma-project.io,resources=compassmanagermappings,verbs=create;get;list;delete | ||
| //+kubebuilder:rbac:groups=operator.kyma-project.io,resources=compassmanagermappings,verbs=create;get;list;delete;watch |
There was a problem hiding this comment.
Compass Manager also needs the update method in RBAC to perform Upsert could you add it?
| @@ -27,6 +27,27 @@ var _ = Describe("Compass Manager controller", func() { | |||
| kymaCustomResourceLabels := make(map[string]string) | |||
| kymaCustomResourceLabels["operator.kyma-project.io/managed-by"] = "lifecycle-manager" | |||
|
|
|||
| It("handles `compass-runtime-id-for-migration`", func() { | |||
There was a problem hiding this comment.
When creating a test case we follow this pattern: Describe -> Context -> It / DescribeTable. Could you adjust this test case to the pattern? You can check how the other tests are described.
|
Could you also perform |
mvshao
reviewed
Oct 13, 2023
| kymaAnnotations, err := cm.getKymaAnnotations(req.NamespacedName) | ||
| if err != nil { | ||
| cm.Log.Warnf("Failed to obtain annotations from Kyma resource %s: %v.", req.Name, err) | ||
| return ctrl.Result{RequeueAfter: cm.requeueTime}, err |
There was a problem hiding this comment.
RequeueAfter doesn't work if error was returned from Reconcile. Consider this flow
- if the error is from the k8s
client-gomethod e.g.Get,List,Updatethe controller should set itself to Error state - if the error results from any other component such as a problem with connection to Compass Director etc, the request should be requeueed in
RequeueAfterwithnilerror. Before return we should log.Warn with message.
mvshao
previously approved these changes
Oct 18, 2023
to satisfy trivy
mvshao
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)