Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a finaliser #46

Merged
merged 27 commits into from
Dec 6, 2023
Merged

Add a finaliser #46

merged 27 commits into from
Dec 6, 2023

Conversation

VOID404
Copy link
Contributor

@VOID404 VOID404 commented Nov 15, 2023 •
edited
Loading

Description

Add kyma-project.io/cm-protection finaliser to CompassManagerMapping

Related issue(s)

@VOID404 VOID404 requested a review from a team as a code owner November 15, 2023 08:50
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 15, 2023
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 23, 2023
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 29, 2023
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 2, 2023
koala7659
koala7659 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 6, 2023
@kyma-bot kyma-bot merged commit 5c6d1ca into kyma-project:main Dec 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koala7659 koala7659 koala7659 approved these changes

Assignees

@koala7659 koala7659

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VOID404 @koala7659 @kyma-bot