Controller triggers only when App Conn module in status was updated
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvshao
added
the
area/application-connector
kyma-bot
added
cla: yes
tobiscr
reviewed
Dec 14, 2023
| func (cm *CompassManagerReconciler) needsToBeReconciledUpdate(oldObj, newObj runtime.Object) bool { | ||
| oldKymaObj, ok := oldObj.(*kyma.Kyma) | ||
| if !ok { | ||
| cm.Log.Error("Unexpected type detected. Old object is supposed to be of the Kyma type.") |
There was a problem hiding this comment.
Could we maybe also print the current type of the object? Just to know better why the casting failed.
| } | ||
| newKymaObj, ok := newObj.(*kyma.Kyma) | ||
| if !ok { | ||
| cm.Log.Error("Unexpected type detected. New object is supposed to be of the Kyma type.") |
tobiscr
reviewed
Dec 14, 2023
| } | ||
|
|
||
| func getModuleNames(modules []kyma.ModuleStatus) []string { | ||
| var result []string |
There was a problem hiding this comment.
For performance reasons, using a map would avoid the looping over arrays - probably a bit more memory expensive as a plain array, but I asume the amount of modules will probably never grow to several thousands.
e.g.
cache := make (map[string]bool,len(modules))
for _, item := range modules {
cache[item.Name] = true
}
//checking for an entry in the map
if _, exists := cache["modulename"]; !exists { fmt.Println("This module doens't exist") }
There was a problem hiding this comment.
Could we postpone this implementation for a while?
tobiscr
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For now, the controller is looking for the Application Connector module in
statusfield, but we encountered a bug, that PR will fix.Changes proposed in this pull request:
statuson Kyma CR is updated the controller is not triggered unless changes are related toapplication-connectormodule nameRelated issue(s)