Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics #67

Merged
merged 12 commits into from
Dec 18, 2023
Merged

Add metrics #67

merged 12 commits into from
Dec 18, 2023

Conversation

VOID404
Copy link
Contributor

@VOID404 VOID404 commented Dec 14, 2023

Description

Initial metrics PR, more metrics will be added when dashboard is connected

Related issue(s)

#28

@VOID404 VOID404 requested a review from a team as a code owner December 14, 2023 08:34
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 14, 2023
@VOID404 VOID404 changed the title Add some metrics [WIP] Add metrics Dec 14, 2023
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 14, 2023
@VOID404 VOID404 changed the title [WIP] Add metrics Add metrics Dec 15, 2023
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2023
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 15, 2023
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks OK, one small thing to fix: please run go mod tidy command to include prometheus client dependency into go.mod file
image

@VOID404 VOID404 requested a review from koala7659 December 18, 2023 08:46
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 18, 2023
@kyma-bot kyma-bot merged commit 554b286 into kyma-project:main Dec 18, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants