Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add URL to Compass Director as env parameter #82

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Add URL to Compass Director as env parameter #82

merged 2 commits into from
Dec 28, 2023

Conversation

mvshao
Copy link
Contributor

@mvshao mvshao commented Dec 27, 2023

Description

Changes proposed in this pull request:

  • add URL to Compass Director as env parameter

Related issue(s)

@mvshao mvshao requested a review from a team as a code owner December 27, 2023 12:36
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 27, 2023
@mvshao
Copy link
Contributor Author

mvshao commented Dec 27, 2023

/test pull-compass-manager-tests

koala7659
koala7659 approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 28, 2023
@kyma-bot kyma-bot merged commit 37a8506 into kyma-project:main Dec 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koala7659 koala7659 koala7659 approved these changes

Assignees

@koala7659 koala7659

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvshao @koala7659 @kyma-bot