Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry run flag #95

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Dry run flag #95

merged 3 commits into from
Jan 15, 2024

Conversation

VOID404
Copy link
Contributor

@VOID404 VOID404 commented Jan 11, 2024

Description

Changes proposed in this pull request:

Implement a dry run switch, which stops Compass Managger from registering runtimes and configuring clusters. Operations that would be made has the dry run flag not been enabled will be logged and tagged [DRY]. Compass manager mappings will still be created, with random UUIDS and tagged compass-manager-dry-run: Yes

Related issue(s)

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 11, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 11, 2024
@VOID404 VOID404 marked this pull request as ready for review January 12, 2024 08:28
@VOID404 VOID404 requested a review from a team as a code owner January 12, 2024 08:28
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2024
@VOID404 VOID404 self-assigned this Jan 12, 2024
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 15, 2024
@kyma-bot kyma-bot merged commit c042903 into kyma-project:main Jan 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants