Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read ias secret #11

Merged
merged 6 commits into from
Apr 27, 2023
Merged

Read ias secret #11

merged 6 commits into from
Apr 27, 2023

Conversation

muralov
Copy link
Contributor

@muralov muralov commented Apr 26, 2023 •
edited by triffer
Loading

Description
Read ias credentials from a K8s secret dynamically for every reconciliation request
Changes proposed in this pull request:

  • Implementation logic
  • Unit tests

Related issue(s)

@muralov muralov requested review from a team and triffer as code owners April 26, 2023 07:25
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 26, 2023
triffer
triffer reviewed Apr 26, 2023
View reviewed changes
internal/ias/ias_config.go Outdated Show resolved Hide resolved
controllers/eventingauth_controller.go Outdated Show resolved Hide resolved
cmd/main.go Show resolved Hide resolved
@kyma-bot kyma-bot added the area/ci Issues or PRs related to CI related topics label Apr 27, 2023
@muralov
Copy link
Contributor Author

muralov commented Apr 27, 2023

/test pull-eventing-auth-manager-unit-test

@triffer triffer self-requested a review April 27, 2023 07:14
triffer
triffer approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@triffer triffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍

@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 27, 2023
@kyma-bot kyma-bot merged commit 878c11f into kyma-project:main Apr 27, 2023
@muralov muralov deleted the read-ias-secret branch April 27, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triffer triffer triffer approved these changes

Assignees

@triffer triffer

Labels
area/ci Issues or PRs related to CI related topics lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muralov @triffer @kyma-bot