Implement Eventing Auth Kyma Controller #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyma controller watches Kyma CRs and creates EventingAuth CRs accordingly
kyma-bot
added
the
size/XXL
triffer
reviewed
May 5, 2023
There was a problem hiding this comment.
I think we should adapt the documentation
- Kyma CRD needs to be in the cluster for local development. I also see that we are not mentioning make install in Running on the cluster, it's only mentioned here.
- Running on the cluster is a little bit different, since KymaCR should be the trigger not EventingAuth
- EVENTING_AUTH_CR_NAME might be better replaced with KYMA_CR_NAME in the readme
* Prevent reconciling every minute * Improve documentation * Don't create/delete kcp-system namespace * Test improvements
triffer
reviewed
May 8, 2023
controllers/kyma_controller.go
Outdated
| if err != nil { | ||
| if apiErrors.IsNotFound(err) { | ||
| return ctrl.Result{ | ||
| RequeueAfter: r.defaultRequeuePeriod, |
There was a problem hiding this comment.
I think that in this case we should not set a RequeueAfter, otherwise this object will be constantly reconciled, even after deletion.
I think I'll remove the defaultRequeuePeriod in my integration test PR, since this was only introduced to control the reconcile for the tests. And it's a better option set the SyncPeriod oder the manager used for the tests and keep the default behaviour.
Suggested change
| RequeueAfter: r.defaultRequeuePeriod, |
triffer
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement Kyma Controller that watchers Kyma CR and creates a EventingAuth CR correspondingly.
Changes proposed in this pull request:
Related issue(s)
#13