Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete IAS Application if SKR cluster is not f ound #35

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Delete IAS Application if SKR cluster is not f ound #35

merged 3 commits into from
Jul 25, 2023

Conversation

muralov
Copy link
Contributor

@muralov muralov commented Jul 19, 2023 •
edited
Loading

Description
Delete IAS application even if SKR kubeconfig is missing. We assume SKR kubeconfig absence means SKR cluster is gone.

Related issue(s)
#34

@muralov
Retry if SKR k8s secret cannot be deleted
c9de528 
* Retry SKR k8s secret delete and delete IAS app if if it still cannot be deleted
@muralov muralov requested a review from a team as a code owner July 19, 2023 19:47
@muralov muralov requested a review from friedrichwilken July 19, 2023 19:47
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 19, 2023
muralov
muralov commented Jul 20, 2023
View reviewed changes
Copy link
Contributor Author

@muralov muralov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...

@muralov muralov linked an issue Jul 20, 2023 that may be closed by this pull request
The EventingAuth CR is not deleted even though the Kyma cluster was deleted #34
Closed
@mfaizanse mfaizanse requested review from k15r and removed request for friedrichwilken July 20, 2023 09:05
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 25, 2023
@muralov
Copy link
Contributor Author

muralov commented Jul 25, 2023

/retest

1 similar comment
@muralov
Copy link
Contributor Author

muralov commented Jul 25, 2023

/retest

@muralov muralov changed the title Retry if SKR k8s secret cannot be deleted Delete IAS Application if SKR cluster is not f ound Jul 25, 2023
@muralov
Copy link
Contributor Author

muralov commented Jul 25, 2023

/test pull-eventing-auth-manager-unit-test

@muralov
Copy link
Contributor Author

muralov commented Jul 25, 2023

/retest

1 similar comment
@muralov
Copy link
Contributor Author

muralov commented Jul 25, 2023

/retest

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 25, 2023
@kyma-bot kyma-bot merged commit 6ae5684 into kyma-project:main Jul 25, 2023
@muralov muralov deleted the fix-secret-delete branch July 25, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k15r k15r k15r approved these changes

Assignees

@k15r k15r

Labels
lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The EventingAuth CR is not deleted even though the Kyma cluster was deleted
3 participants
@muralov @k15r @kyma-bot