Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Deleting EventingAuth #6

Merged
merged 3 commits into from
Apr 19, 2023

Conversation

muralov
Copy link
Contributor

@muralov muralov commented Apr 19, 2023

Implements delete functional of EventingAuth resource

  • Implements deleting IAS app & secret
  • Implements deleting k8s secret

@muralov muralov requested review from a team and triffer as code owners April 19, 2023 08:09
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 19, 2023
muralov added 3 commits April 19, 2023 11:46
* Implement deleting IAS app & secret
* Implement deleting k8s secret
* Use CR  name as IAS app name
* Delete erro log for not found resource
@triffer triffer self-requested a review April 19, 2023 11:33
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 19, 2023
@kyma-bot kyma-bot merged commit 0a3c7cc into kyma-project:main Apr 19, 2023
@muralov muralov deleted the delete-feature branch April 19, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants