Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADR for extending Istio CR with support for AWS LB type #1117

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

ADR for extending Istio CR with support for AWS LB type #1117

wants to merge 4 commits into from

Conversation

videlov
Copy link
Contributor

@videlov videlov commented Nov 13, 2024

Description

Changes proposed in this pull request:

  • ADR for extending Istio CR with support for AWS LB type

Pre-Merge Checklist

  • As a PR reviewer, verify code coverage and evaluate if it is acceptable.

Related issues

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2024
@videlov videlov requested a review from a team November 13, 2024 15:26
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 13, 2024
@videlov videlov marked this pull request as ready for review November 14, 2024 14:54
@videlov videlov requested a review from a team as a code owner November 14, 2024 14:54
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2024
triffer
triffer reviewed Nov 15, 2024
View reviewed changes
docs/contributor/adr/0010-aws-nlb-support.md Outdated Show resolved Hide resolved
docs/contributor/adr/0010-aws-nlb-support.md
awsLoadBalancerType: nlb
```

* When switching to NLB Istio Module operator should apply additionally the following `serviceAnnotations` with Istio Operator Manifest:
Copy link
Contributor

@triffer triffer Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this warning in the AWS load balancer controller docs:

It's not recommended to modify or add the service.beta.kubernetes.io/aws-load-balancer-type annotation on an existing Service resource. If a change is desired, delete the existing Service resource and create a new one instead of modifying an existing Service.

If you modify this annotation on an existing Service resource, you might end up with leaked LBC resources.

see https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.10/guide/service/nlb/

It looks like it would be better to create bew services for each LB type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets discuss on Monday, how we are going to approach this. Since downtime is a thing to consider.

@videlov @triffer
Update docs/contributor/adr/0010-aws-nlb-support.md
e467836 
Co-authored-by: Tim Riffer <tim.riffer@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triffer triffer triffer left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@videlov @triffer @kyma-bot