Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Istio CR with Egress Gateway #1178

Merged
merged 12 commits into from
Dec 18, 2024
Merged

Extend Istio CR with Egress Gateway #1178

merged 12 commits into from
Dec 18, 2024

Conversation

werdes72
Copy link
Contributor

@werdes72 werdes72 commented Dec 9, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Add Egress Gateway to Istio custom resource API
  • Add Egress Gateway restarter Not needed, will use sidecar restarter
  • Unit tests
  • Integration tests

Pre-Merge Checklist

  • As a PR reviewer, verify code coverage and evaluate if it is acceptable.

Related issues
#1159

@werdes72 werdes72 requested a review from a team as a code owner December 9, 2024 08:23
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 9, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2024
@werdes72 werdes72 requested a review from a team as a code owner December 12, 2024 12:35
@werdes72 @nataliasitko
Update docs/user/04-00-istio-custom-resource.md
f657e9a 
Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>
nataliasitko
nataliasitko previously approved these changes Dec 13, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 13, 2024
videlov
videlov requested changes Dec 16, 2024
View reviewed changes
api/v1alpha2/merge_test.go Outdated Show resolved Hide resolved
api/v1alpha2/merge_test.go Show resolved Hide resolved
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 16, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 17, 2024
nataliasitko
nataliasitko previously approved these changes Dec 17, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 17, 2024
videlov
videlov requested changes Dec 17, 2024
View reviewed changes
internal/filter/predicate.go Outdated Show resolved Hide resolved
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 17, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 18, 2024
@werdes72 werdes72 merged commit d701d2a into kyma-project:main Dec 18, 2024
29 of 30 checks passed
@werdes72 werdes72 deleted the egress-istio-cr branch December 18, 2024 08:42
@werdes72 werdes72 mentioned this pull request Dec 18, 2024
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliasitko nataliasitko nataliasitko approved these changes

@videlov videlov videlov approved these changes

Assignees

@videlov videlov

@nataliasitko nataliasitko

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@werdes72 @videlov @nataliasitko @kyma-bot