Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt HPA values and scaling base #819

Merged
merged 5 commits into from
May 21, 2024
Merged

Conversation

barchw
Copy link
Contributor

@barchw barchw commented May 14, 2024

Description

Changes proposed in this pull request:

  • Adapt HPA values and scaling base

@barchw barchw requested review from a team as code owners May 14, 2024 07:17
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 14, 2024
@barchw barchw mentioned this pull request May 14, 2024
4 tasks
@barchw barchw added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2024
@barchw
Copy link
Contributor Author

barchw commented May 15, 2024

We need to decide whether it is acceptable that performance tests results are raised.
If not, we should adapt the HPA to a better value

triffer
triffer previously approved these changes May 16, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 16, 2024
@barchw
Copy link
Contributor Author

barchw commented May 16, 2024

We need to decide whether it is acceptable that performance tests results are raised. If not, we should adapt the HPA to a better value

After multiple re-runs and watching how the resource values are progressing, the memory value never get's over the 80% threshold that was previously set.
As so, removing memory from the HPA should not have any effect, seems that the results I got before were just outlying

@kyma-bot kyma-bot removed the lgtm Looks good to me! label May 16, 2024
docs/release-notes/1.7.0.md Outdated Show resolved Hide resolved
docs/release-notes/1.7.0.md Outdated Show resolved Hide resolved
Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>
nataliasitko
nataliasitko previously approved these changes May 21, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 21, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label May 21, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 21, 2024
@barchw barchw removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@kyma-bot kyma-bot merged commit 0e2c735 into kyma-project:main May 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants