Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip restart of pods with proxies with istio's custom image annotation #823

Merged
merged 7 commits into from
May 21, 2024
Merged

Skip restart of pods with proxies with istio's custom image annotation #823

merged 7 commits into from
May 21, 2024

Conversation

kolodziejczak
Copy link
Contributor

@kolodziejczak kolodziejczak commented May 16, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Skip restart of pods with sidecar proxies and Istio's annotations setting custom proxy image

@kolodziejczak kolodziejczak requested a review from a team as a code owner May 16, 2024 11:35
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 16, 2024
@kolodziejczak kolodziejczak requested a review from a team as a code owner May 16, 2024 12:05
@kolodziejczak kolodziejczak mentioned this pull request May 16, 2024
Closed
5 tasks
@kolodziejczak kolodziejczak force-pushed the proxy-restart-annotation branch from 84991db to cf3c505 Compare May 16, 2024 12:23
nataliasitko
nataliasitko reviewed May 21, 2024
View reviewed changes
docs/release-notes/1.7.0.md Outdated Show resolved Hide resolved
docs/user/00-30-overview-istio-sidecars.md Outdated Show resolved Hide resolved
docs/user/00-30-overview-istio-sidecars.md Outdated Show resolved Hide resolved
triffer
triffer reviewed May 21, 2024
View reviewed changes
docs/user/00-30-overview-istio-sidecars.md Outdated Show resolved Hide resolved
pkg/lib/sidecars/pods/filter_test.go Outdated Show resolved Hide resolved
@kolodziejczak @triffer
Update pkg/lib/sidecars/pods/filter_test.go
c8b7317 
Co-authored-by: Tim Riffer <tim.riffer@gmx.de>
@kolodziejczak @nataliasitko
Apply suggestions from code review
9e376df 
Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>
@triffer triffer self-requested a review May 21, 2024 07:35
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 21, 2024
@kyma-bot kyma-bot merged commit 8628aaa into kyma-project:main May 21, 2024
15 checks passed
@kolodziejczak kolodziejczak deleted the proxy-restart-annotation branch August 12, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@werdes72 werdes72 werdes72 left review comments

@nataliasitko nataliasitko nataliasitko approved these changes

@triffer triffer triffer approved these changes

Assignees

@triffer triffer

@nataliasitko nataliasitko

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kolodziejczak @werdes72 @triffer @nataliasitko @kyma-bot