Improve memory usage of Istio manager #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
barchw
changed the title
triffer
reviewed
Jun 3, 2024
| for _, pod := range podList.Items { | ||
| if evaluator.RequiresProxyRestart(pod) { | ||
| outputPodsList.Items = append(outputPodsList.Items, *pod.DeepCopy()) | ||
| outputPodsList.Items = append(outputPodsList.Items, pod) |
There was a problem hiding this comment.
Maybe a micro-optimization since the pod objects are not that big, but I think we will create multiple backing arrays, since the capacity of the slices will increase multiple times. That will lead to multiple arrays being kept in memory until the outputPodList isn't referenced any longer and can be garbage collected.
We could initialize the outputPodsList.Items with a capacity derived from podList.Items length.
| @@ -107,6 +109,16 @@ func main() { | |||
| HealthProbeBindAddress: flagVar.probeAddr, | |||
| LeaderElection: flagVar.enableLeaderElection, | |||
| LeaderElectionID: "76223278.kyma-project.io", | |||
| Client: client.Options{ | |||
| Cache: &client.CacheOptions{ | |||
| DisableFor: []client.Object{ | |||
There was a problem hiding this comment.
Should we add a comment that explains why we disable the cache for this types?
kyma-bot
added
size/L
kyma-bot
added
size/M
triffer
approved these changes
Jun 3, 2024
barchw
added a commit
to barchw/istio
that referenced
this pull request
Jun 4, 2024
* Use distinct path for Istio telemetries * Remove deepcopy from gathering pods for restart * Revert unneded * Remove caching for objects * Post review * Use distinct path for Istio telemetries * Remove deepcopy from gathering pods for restart * Revert unneded * Remove caching for objects * Post review
kyma-bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
* Improve memory usage of Istio manager (#852) * Use distinct path for Istio telemetries * Remove deepcopy from gathering pods for restart * Revert unneded * Remove caching for objects * Post review * Use distinct path for Istio telemetries * Remove deepcopy from gathering pods for restart * Revert unneded * Remove caching for objects * Post review * Run tests on Gardener live (#851) * Deprecate kyma provision gardener (#825) * Deprecate kyma provision gardener * fixes * use relative yaml path * fix yaml path again * force k8s version to be a string * try delaying before requesting kubeconfig * don't hibernate * fix varaible name * remove sleep * remove unused GARDENER_GARDENLINUX_VERSION * fix Gardener provisioning (#835) * Use the default Gardener network addresses (#840) * Use the default Gardener network addresses * aws * [skip ci] * Don't skip ci * Dummy --------- Co-authored-by: Patryk Strugacz <werdes72@users.noreply.github.com> Co-authored-by: Piotr Halama <piotr.halama@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issues