Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare Istio documentation for migration to Help Portal #999

Merged
merged 25 commits into from
Oct 30, 2024
Merged

Prepare Istio documentation for migration to Help Portal #999

merged 25 commits into from
Oct 30, 2024

Conversation

nataliasitko
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Adjust the documentation to the Help Portal template
  • Join Service Mesh overview and Istio Sidecars overview
  • Join default Istio setup and Istio Default Resource configuration docs

Pre-Merge Checklist

  • As a PR reviewer, verify code coverage and evaluate if it is acceptable.

Related issues

@nataliasitko nataliasitko requested review from a team as code owners August 30, 2024 13:00
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 30, 2024
@nataliasitko nataliasitko added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 30, 2024
@kyma-bot kyma-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 11, 2024
barchw
barchw requested changes Oct 8, 2024
View reviewed changes
docs/user/00-15-overview-istio-setup.md Outdated Show resolved Hide resolved
docs/user/00-15-overview-istio-setup.md Outdated Show resolved Hide resolved
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 22, 2024
@nataliasitko nataliasitko removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 23, 2024
@kyma-bot kyma-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 23, 2024
IwonaLanger
IwonaLanger reviewed Oct 24, 2024
View reviewed changes
docs/user/00-00-istio-sidecar-proxies.md Outdated Show resolved Hide resolved
docs/user/00-00-istio-sidecar-proxies.md Outdated Show resolved Hide resolved
docs/user/00-00-istio-sidecar-proxies.md Outdated Show resolved Hide resolved
docs/user/00-00-istio-sidecar-proxies.md Show resolved Hide resolved
docs/user/00-00-istio-sidecar-proxies.md Outdated Show resolved Hide resolved
docs/user/troubleshooting/03-30-istio-no-sidecar.md Outdated Show resolved Hide resolved
docs/user/troubleshooting/03-30-istio-no-sidecar.md Outdated Show resolved Hide resolved
docs/user/troubleshooting/03-30-istio-no-sidecar.md Outdated Show resolved Hide resolved
docs/user/troubleshooting/03-30-istio-no-sidecar.md Outdated Show resolved Hide resolved
docs/user/troubleshooting/03-30-istio-no-sidecar.md Outdated Show resolved Hide resolved
IwonaLanger
IwonaLanger reviewed Oct 24, 2024
View reviewed changes
docs/user/troubleshooting/03-50-recovering-from-unintentional-istio-removal.md Outdated Show resolved Hide resolved
docs/user/troubleshooting/03-50-recovering-from-unintentional-istio-removal.md Show resolved Hide resolved
docs/user/troubleshooting/03-50-recovering-from-unintentional-istio-removal.md Outdated Show resolved Hide resolved
docs/user/troubleshooting/03-50-recovering-from-unintentional-istio-removal.md Show resolved Hide resolved
docs/user/troubleshooting/03-50-recovering-from-unintentional-istio-removal.md Show resolved Hide resolved
docs/user/tutorials/01-40-enable-sidecar-injection.md Outdated Show resolved Hide resolved
docs/user/tutorials/01-40-enable-sidecar-injection.md Outdated Show resolved Hide resolved
docs/user/tutorials/01-45-enable-istio-access-logs.md Outdated Show resolved Hide resolved
docs/user/tutorials/01-45-enable-istio-access-logs.md Outdated Show resolved Hide resolved
docs/user/tutorials/01-45-enable-istio-access-logs.md Outdated Show resolved Hide resolved
@nataliasitko @IwonaLanger
Apply suggestions from code review
27d5600 
Co-authored-by: Iwona Langer <iwona.langer@sap.com>
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 30, 2024
@nataliasitko nataliasitko merged commit f2d5ba8 into kyma-project:main Oct 30, 2024
17 checks passed
@nataliasitko nataliasitko deleted the migration-prep1 branch October 30, 2024 08:41
This was referenced Oct 31, 2024
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IwonaLanger IwonaLanger IwonaLanger approved these changes

@barchw barchw barchw approved these changes

Assignees

@barchw barchw

@IwonaLanger IwonaLanger

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nataliasitko @barchw @IwonaLanger @kyma-bot