Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Patch request to update EventMesh subscriptions Webhook Auth in Eventing controller #17370

Closed
6 tasks done
k15r opened this issue Apr 21, 2023 · 7 comments · Fixed by #17709, #17786 or #17796
Closed
6 tasks done
Assignees
Labels
area/eventing Issues or PRs related to eventing

Comments

@k15r
Copy link
Contributor

k15r commented Apr 21, 2023

Context:
Currently, whenever we have to update the eventMesh subscriptions, we delete and re-create the subscription on EventMesh server. Idea: we can use the PATCH request to update instead of deleting and re-creating!!!

Description
In order to update the client credentials used by event mesh we need to implement a PATCH request as documented here:
https://api.sap.com/api/SAPEventMeshDefaultCredentialsAPIs/resource/Webhook_Credentials_Management

Tasks:

Acceptance

  • We can update EventMesh subscription without deleting it.
  • existing webhooks can be updated to use a new set of credentials
@k15r k15r changed the title configure the eventmesh webhook to use these credentials Update credentials of existing webhooks Apr 21, 2023
@mfaizanse mfaizanse changed the title Update credentials of existing webhooks Use PUT request to update EventMesh subscriptions in Eventing controller Apr 21, 2023
@mfaizanse mfaizanse self-assigned this May 2, 2023
@mfaizanse
Copy link
Member

Blocked!

We are using POST /events/subscriptions API and we want to provide the name of webhook-credentials which we created using these APIs, is it supported?

@mfaizanse
Copy link
Member

mfaizanse commented May 5, 2023

@mfaizanse mfaizanse removed their assignment May 5, 2023
@mfaizanse
Copy link
Member

Use these APIs to:

  1. Pause the EventMesh subscription.
  2. Update the Auth credentials.
  3. Unpause the EventMesh subscription.

@mfaizanse mfaizanse changed the title Use PUT request to update EventMesh subscriptions in Eventing controller Use Patch request to update EventMesh subscriptions Webhook Auth in Eventing controller May 5, 2023
@marcobebway marcobebway self-assigned this May 9, 2023
@marcobebway
Copy link
Contributor

marcobebway commented May 11, 2023

Blocked because the patch request returns the following error:

{
    "error": {
        "code": "INTERNAL_SERVER_ERROR",
        "message": "Error occurred in the system"
    }
}

@marcobebway marcobebway added the area/eventing Issues or PRs related to eventing label May 12, 2023
@k15r
Copy link
Contributor Author

k15r commented May 15, 2023

To unblock this ticket, during implementation and test fall back to using a MOCK

@marcobebway
Copy link
Contributor

Moving to blocked because the PATCH request is returning 5xx.

@marcobebway
Copy link
Contributor

Moving to blocked because the PATCH request is caching the secret and is not sensitive to changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment