Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the APIRule and webhook configs for EventMesh to allow validating the presented token. #17371

Closed
4 of 5 tasks
Tracked by #17490
k15r opened this issue Apr 21, 2023 · 5 comments · Fixed by #17632
Closed
4 of 5 tasks
Tracked by #17490
Assignees
Labels
area/eventing Issues or PRs related to eventing

Comments

@k15r
Copy link
Contributor

k15r commented Apr 21, 2023

Description

Use the credentials based on IAS, if corresponding secret exists in the cluster.

Tasks:

  • Use the credentials from new secret in Webhook configs provided to EventMesh Subscriptions. (eventing-webhook-auth in kyma-system)
  • Create/Update the APIRule with correct accessStrategies. More info here.
  • NOTE: There is a POC PR for reference.

Acceptance criteria

  • APIRules can be created / updated to use credentials based on IAS.
  • EventMesh subscription Webhook configs can be created to use credentials based on IAS.

Acceptance criteria blocked

@mfaizanse mfaizanse changed the title update the apirule to allow validating the presented token. Update the APIRule and webhook configs for EventMesh to allow validating the presented token. Apr 26, 2023
@muralov
Copy link
Contributor

muralov commented Apr 28, 2023

eventing-webhook-auth secret fields can be seen here

@k15r
Copy link
Contributor Author

k15r commented Apr 28, 2023

Rollout of the new feature:

  1. update control plane with eventing-auth-manager to install the new secret on every cluster
  2. update eventing controller to use the new functionality

That way we can remove all ory dependencies with the rollout and to not have to implement a switching logic between old and new secret

Requires:

  • feature flag in ec to enable the new feature
  • secret to be used by prow / local dev setup

@k15r
Copy link
Contributor Author

k15r commented May 25, 2023

Switch behaviour based on the newly introduced feature switch

@mfaizanse mfaizanse added the area/eventing Issues or PRs related to eventing label May 26, 2023
@friedrichwilken
Copy link
Contributor

friedrichwilken commented Jun 3, 2023

What is IAS? Can you provide a link? Where can I find the "new secret in Webhook configs"? How can I access it? Where can I find the API-Rule that is supposed to be updated? What is the "presented token"? Why doesn't the ticket mention that it has a parent ticket and that it is part of an epic? Why are the parent and the epic not linked?

@friedrichwilken
Copy link
Contributor

friedrichwilken commented Jun 3, 2023

IAS - Identity Authentication Service by SAP.
The aforementioned secret is the eventing-webhook-auth in the kyma-system namespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants