Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend existing in-cluster eventing test in fast-integration #12085

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Extend existing in-cluster eventing test in fast-integration #12085

merged 1 commit into from
Sep 13, 2021

Conversation

pxsalehi
Copy link
Contributor

@pxsalehi pxsalehi commented Sep 10, 2021 •
edited by mmitoraj
Loading

Description

Changes proposed in this pull request:

  • Extend existing in-cluster eventing test in fast-integration to support binary-mode cloud events

@pxsalehi pxsalehi added the area/eventing Issues or PRs related to eventing label Sep 10, 2021
@pxsalehi pxsalehi self-assigned this Sep 10, 2021
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2021
wozniakjan
wozniakjan approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 13, 2021
@kyma-bot kyma-bot merged commit 1d82736 into kyma-project:main Sep 13, 2021
@kyma-bot
Copy link
Contributor

@pxsalehi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pre-main-kyma-gardener-azure-integration-cosigned cf05db7 link /test pre-main-kyma-gardener-azure-integration-cosigned

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

pxsalehi added a commit to pxsalehi/kyma that referenced this pull request Sep 16, 2021
@pxsalehi
add binary mode to in-cluster eventing test (kyma-project#12085)
40bdcaa
kyma-bot pushed a commit that referenced this pull request Sep 17, 2021
@pxsalehi
Cherry-pick #12085 #12115 (add binary mode to in-cluster eventing tes…
a939216 
…t) (#12113)

* add binary mode to in-cluster eventing test (#12085)

* move in-cluster sub-test to fixture
@Ressetkk Ressetkk mentioned this pull request Sep 20, 2021
Closed
@k15r k15r mentioned this pull request Feb 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wozniakjan wozniakjan wozniakjan approved these changes

@adamwalach adamwalach Awaiting requested review from adamwalach

@crabtree crabtree Awaiting requested review from crabtree

@jeremyharisch jeremyharisch Awaiting requested review from jeremyharisch

@lindnerby lindnerby Awaiting requested review from lindnerby

@pbochynski pbochynski Awaiting requested review from pbochynski

@rakesh-garimella rakesh-garimella Awaiting requested review from rakesh-garimella

@shorim shorim Awaiting requested review from shorim

@skhalash skhalash Awaiting requested review from skhalash

@voigt voigt Awaiting requested review from voigt

Assignees

@wozniakjan wozniakjan

@pxsalehi pxsalehi

Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pxsalehi @kyma-bot @wozniakjan