Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cloud Event (Binary Content Mode) processing for NATS backend ( release 1.24.6 ) #12102

Merged
merged 1 commit into from Sep 16, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 14, 2021

Description
Fix json unmarshal error in event controller with NATS backend, for Cloud Events in Binary Content Mode.

Changes proposed in this pull request:

  • Upgrade to "github.com/cloudevents/sdk-go/v2 v2.4.1"

Related issue(s)

See #12093

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 14, 2021
@ghost ghost changed the title Fix Cloud Event (Binary Content Mode) for NATS backend ( release 1.24.6 ) Fix Cloud Event (Binary Content Mode) processing for NATS backend ( release 1.24.6 ) Sep 14, 2021
@ghost ghost self-assigned this Sep 14, 2021
@ghost ghost added the area/eventing Issues or PRs related to eventing label Sep 14, 2021
@ghost ghost linked an issue Sep 14, 2021 that may be closed by this pull request
@ghost
Copy link
Author

ghost commented Sep 14, 2021

/retest

@ghost
Copy link
Author

ghost commented Sep 15, 2021

/test all

@ghost
Copy link
Author

ghost commented Sep 15, 2021

/retest

1 similar comment
@ghost
Copy link
Author

ghost commented Sep 15, 2021

/retest

@ghost ghost deleted a comment from kyma-bot Sep 15, 2021
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 15, 2021
@ghost
Copy link
Author

ghost commented Sep 15, 2021

/test all

@sayanh
Copy link
Contributor

sayanh commented Sep 15, 2021

/test pre-rel124-kyma-components-event-publisher-proxy

@sayanh
Copy link
Contributor

sayanh commented Sep 15, 2021

/retest

@kyma-bot kyma-bot merged commit 6cdde1f into kyma-project:release-1.24 Sep 16, 2021
@ghost ghost mentioned this pull request Sep 16, 2021
@k15r k15r mentioned this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud Events (Binary Content Mode) cause json unmarshal error in event controller.
2 participants