-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Cloud Event (Binary Content Mode) processing for NATS backend ( release 1.24.6 ) #12102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
k15r,
lilitgh,
marcobebway,
nachtmaar,
pxsalehi,
sayanh and
themue
as code owners
September 14, 2021 14:10
kyma-bot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Sep 14, 2021
ghost
changed the title
Fix Cloud Event (Binary Content Mode) for NATS backend ( release 1.24.6 )
Fix Cloud Event (Binary Content Mode) processing for NATS backend ( release 1.24.6 )
Sep 14, 2021
ghost
self-assigned this
Sep 14, 2021
ghost
linked an issue
Sep 14, 2021
that may be
closed
by this pull request
/retest |
ghost
removed a link to an issue
Sep 14, 2021
ghost
linked an issue
Sep 14, 2021
that may be
closed
by this pull request
/test all |
/retest |
1 similar comment
/retest |
ghost
deleted a comment from
kyma-bot
Sep 15, 2021
sayanh
approved these changes
Sep 15, 2021
/test all |
/test pre-rel124-kyma-components-event-publisher-proxy |
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/eventing
Issues or PRs related to eventing
lgtm
Looks good to me!
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix json unmarshal error in event controller with NATS backend, for Cloud Events in Binary Content Mode.
Changes proposed in this pull request:
Related issue(s)
See #12093