Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform clean up for impersonate headers #12320

Conversation

Kaktusowy500
Copy link

Description
Request coming to apiserver-proxy component can contain impersonate-group and impersonate-user header. In order to not pass any additional data, we should clean the connection header from impersonate keys.

Changes proposed in this pull request:

  • cleanup connection header before adding user and user's groups

@kyma-bot
Copy link
Contributor

kyma-bot commented Oct 7, 2021

Hi @Kaktusowy500. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 7, 2021
@piotrkpc
Copy link
Contributor

piotrkpc commented Oct 7, 2021

/ok-to-test

1 similar comment
@mjakobczyk
Copy link
Contributor

/ok-to-test

Copy link
Contributor

@mjakobczyk mjakobczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 7, 2021
@kyma-bot kyma-bot merged commit be4c4de into kyma-project:release-1.24 Oct 7, 2021
@adamwalach adamwalach added the area/security Issues or PRs related to security label Oct 14, 2021
@k15r k15r mentioned this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security Issues or PRs related to security lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants