Remove azure broker from kyma installation #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polskikiel
added
area/documentation
polskikiel
requested review from
a-thaler,
adamwalach,
aszecowka,
bszwarc,
crabtree,
Demonsthere,
derberg,
jakkab,
jasiu001,
kazydek,
kfurgol,
klaudiagrz,
kubadz,
lszymik,
mszostok,
mwieczorek,
pbochynski,
piotrmiskiewicz,
piotrmsc,
PK85,
sjanota,
strekm,
Tomasz-Smelcerz-SAP,
tomekpapiernik,
venturasr and
a team
as code owners
polskikiel
commented
Jan 16, 2019
| @@ -14,14 +14,14 @@ To specify whether to install a given core subcomponent on Minikube, use the `ma | |||
|
|
|||
| Example: | |||
|
|
|||
| To enable the Azure Broker subcomponent, run the following command: | |||
| To disable the API-Controller subcomponent, run the following command: | |||
There was a problem hiding this comment.
why do you describe PAI controller in this PR?
There was a problem hiding this comment.
discussed. it was used as the example
piotrmiskiewicz
requested changes
Jan 24, 2019
| @@ -14,14 +14,14 @@ To specify whether to install a given core subcomponent on Minikube, use the `ma | |||
|
|
|||
| Example: | |||
|
|
|||
| To enable the Azure Broker subcomponent, run the following command: | |||
| To disable the API-Controller subcomponent, run the following command: | |||
There was a problem hiding this comment.
why do you describe PAI controller in this PR?
piotrmiskiewicz
approved these changes
Jan 24, 2019
|
/retest |
1 similar comment
|
/retest |
PK85
approved these changes
Jan 25, 2019
klaudiagrz
approved these changes
Jan 25, 2019
|
/retest |
Tomasz-Smelcerz-SAP
approved these changes
Jan 25, 2019
|
/retest |
|
/test pre-master-kyma-gke-integration |
|
please remove resources/core/charts/azure-broker folder |
crabtree
approved these changes
Jan 28, 2019
|
/retest |
|
@polskikiel: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test pre-master-kyma-integration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Blocked until enabling Azure Broker as the bundle
Changes proposed in this pull request:
Related issue(s)
See the PRs in the commercialization and cont-integration repo.