Adjust application-operator for mtls #3666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfurgol
requested review from
akgalwas,
crabtree,
franpog859,
janmedrek,
lszymik,
Maladie and
Szymongib
as code owners
kfurgol
added
the
area/application-connector
Szymongib
reviewed
Apr 11, 2019
|
|
||
| var testContainer string | ||
| for _, c := range pod.Spec.Containers { | ||
| if strings.HasPrefix(c.Name, "test-operator-app-test") { |
There was a problem hiding this comment.
Only one of the tests pods has such prefix, and it is not really clear. I would suggest changing container name in event-service test pod and use Application name as a prefix.
| apiVersion: "networking.istio.io/v1alpha3" | ||
| kind: "DestinationRule" | ||
| metadata: | ||
| name: {{.Release.Name }}-mtls-disable |
There was a problem hiding this comment.
I do not think that this is a proper name as the DestinationRule is set for mock service, not for the {{.Release.Name }} itself.
| @@ -25,3 +25,13 @@ spec: | |||
| - name: MOCK_SERVICE_PORT | |||
| value: "8080" | |||
| restartPolicy: Never | |||
| --- | |||
| apiVersion: "networking.istio.io/v1alpha3" | |||
| kind: "DestinationRule" | |||
There was a problem hiding this comment.
I would suggest moving it to separate file.
Szymongib
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#3320
Related PR: #3385