-
Notifications
You must be signed in to change notification settings - Fork 30
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
split cleanup process to postpone crd deletion after all resources ge…
…t deleted
- Loading branch information
Showing
3 changed files
with
139 additions
and
90 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| package resources | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
|
|
||
| apimetav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/cli-runtime/pkg/resource" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
|
|
||
| "github.com/kyma-project/lifecycle-manager/api/shared" | ||
| "github.com/kyma-project/lifecycle-manager/api/v1beta2" | ||
| "github.com/kyma-project/lifecycle-manager/pkg/common" | ||
| "github.com/kyma-project/lifecycle-manager/pkg/util" | ||
| ) | ||
|
|
||
| var ErrDeletionNotFinished = errors.New("deletion is not yet finished") | ||
|
|
||
| type ConcurrentCleanup struct { | ||
| clnt client.Client | ||
| policy client.PropagationPolicy | ||
| manifest *v1beta2.Manifest | ||
| } | ||
|
|
||
| func NewConcurrentCleanup(clnt client.Client, manifest *v1beta2.Manifest) *ConcurrentCleanup { | ||
| return &ConcurrentCleanup{ | ||
| clnt: clnt, | ||
| policy: client.PropagationPolicy(apimetav1.DeletePropagationBackground), | ||
| manifest: manifest, | ||
| } | ||
| } | ||
|
|
||
| func (c *ConcurrentCleanup) DeleteDiffResources(ctx context.Context, resources []*resource.Info, | ||
| ) error { | ||
| status := c.manifest.GetStatus() | ||
| excludeCRDList, pureCRDList, err := splitResources(resources) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if err := c.CleanupResources(ctx, excludeCRDList, status); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if err := c.CleanupResources(ctx, pureCRDList, status); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func (c *ConcurrentCleanup) CleanupResources( | ||
| ctx context.Context, | ||
| resources []*resource.Info, | ||
| status shared.Status, | ||
| ) error { | ||
| if err := c.Run(ctx, resources); errors.Is(err, ErrDeletionNotFinished) { | ||
| return err | ||
| } else if err != nil { | ||
| c.manifest.SetStatus(status.WithState(shared.StateError).WithErr(err)) | ||
| return err | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func splitResources(resources []*resource.Info) ([]*resource.Info, []*resource.Info, error) { | ||
| excludeCRDList := make([]*resource.Info, 0) | ||
| pureCRDList := make([]*resource.Info, 0) | ||
|
|
||
| for _, resource := range resources { | ||
| obj, ok := resource.Object.(client.Object) | ||
| if !ok { | ||
| return nil, nil, common.ErrTypeAssert | ||
| } | ||
| if obj.GetObjectKind().GroupVersionKind().Kind == "CustomResourceDefinition" { | ||
| pureCRDList = append(pureCRDList, resource) | ||
| continue | ||
| } | ||
| excludeCRDList = append(excludeCRDList, resource) | ||
| } | ||
|
|
||
| return excludeCRDList, pureCRDList, nil | ||
| } | ||
|
|
||
| func (c *ConcurrentCleanup) Run(ctx context.Context, infos []*resource.Info) error { | ||
| // The Runtime Complexity of this Branch is N as only ServerSideApplier Patch is required | ||
| results := make(chan error, len(infos)) | ||
| for i := range infos { | ||
| i := i | ||
| go c.cleanupResource(ctx, infos[i], results) | ||
| } | ||
|
|
||
| var errs []error | ||
| present := len(infos) | ||
| for i := 0; i < len(infos); i++ { | ||
| err := <-results | ||
| if util.IsNotFound(err) { | ||
| present-- | ||
| continue | ||
| } | ||
| if err != nil { | ||
| errs = append(errs, err) | ||
| } | ||
| } | ||
|
|
||
| if len(errs) > 0 { | ||
| return errors.Join(errs...) | ||
| } | ||
|
|
||
| if present > 0 { | ||
| return ErrDeletionNotFinished | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func (c *ConcurrentCleanup) cleanupResource(ctx context.Context, info *resource.Info, results chan error) { | ||
| obj, ok := info.Object.(client.Object) | ||
| if !ok { | ||
| return | ||
| } | ||
| results <- c.clnt.Delete(ctx, obj, c.policy) | ||
| } |