-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ModuleCatalog] Implement Logic for ModuleReleaseMeta
CRD in Kyma Reconcile Loop
#1849
Comments
Can we really cache it? When it changes, we enqueue a reconcile event for the related kymas which should then fetch the up to date version, and not a maybe outdated one from the cache
I think the naming pattern must already be defines as part of #1848. But I think it can be as simple as the module name? |
ModuleReleaseMeta
CRD in Kyma Reconcile LoopModuleReleaseMeta
CRD in Kyma Reconcile Loop
Depends on: #1848 |
<!-- Thank you for your contribution. Before you submit the pull request: 1. Follow contributing guidelines, templates, the recommended Git workflow, and any related documentation. 2. Read and submit the required Contributor Licence Agreements (https://github.com/kyma-project/community/blob/main/CONTRIBUTING.md#agreements-and-licenses). 3. Test your changes and attach their results to the pull request. 4. Update the relevant documentation. If the pull request requires a decision, follow the [decision-making process](https://github.com/kyma-project/community/blob/main/governance.md) and replace the PR template with the [decision record template](https://github.com/kyma-project/community/blob/main/.github/ISSUE_TEMPLATE/decision-record.md). --> **Description** Changes proposed in this pull request: - Introduce module-release-meta to be used in E2E tests **Related issue(s)** kyma-project/lifecycle-manager#1849
Verified this on dev, since no modules use the modulereleasemeta yet. |
Description:
We need to implement the logic to utilize the newly created
ModuleReleaseMeta
CRD in the Kyma reconcile loop. Currently, we fetch and filterModuleTemplates
based on the channel specified inModuleTemplate.spec
. This logic needs to be updated to fetch the appropriateModuleTemplate
by using the information from theModuleReleaseMeta
CRD.Detailed decision ticket: #1815
New Logic:
ModuleTemplates
and filtering by the channel specified inModuleTemplate.spec
, first fetch theModuleReleaseMeta
CR.Kyma.spec
for the module.ModuleReleaseMeta.spec
.ModuleTemplate
based on this version.ModuleReleaseMeta
to simplify the fetching process, it needs to be well-documented (just the module name).ModuleTemplate
CRs as well (modulename-versionnumber)Acceptance Criteria:
ModuleReleaseMeta
for fetchingModuleTemplates
.ModuleReleaseMeta
, including any naming patterns introduced.The text was updated successfully, but these errors were encountered: