feat: enhance Kyma type #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Overall very cool! I like how you kept close to the original k8s specs. Still I am wondering wether we can simply include the API Spec from Deployment as is without introducing custom states. I think we can go ahead either way, just want to bring up the discussion!
| KymaStateReady KymaState = "Ready" | ||
|
|
||
| // KymaStateProcessing signifies Kyma is reconciling | ||
| KymaStateProcessing KymaState = "Processing" |
There was a problem hiding this comment.
Why do we need custom states here instead of reusing the states from Apimachinery (e.g. like Deployment with "Progressing")
|
Also, https://github.com/kyma-project/kyma-operator/blob/main/operator/pkg/client/listers/operator.kyma-project.io/v1alpha1/kyma.go#L95 errors out on main, do you know why that is? possibly related to api spec changes |
jakobmoellerdev
approved these changes
May 2, 2022
jeremyharisch
pushed a commit
to jeremyharisch/lifecycle-manager
that referenced
this pull request
Jul 20, 2023
change trigger type for test
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.