Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ModuleCatalog] Support .spec.associatedResources #54

Closed
10 tasks done
c-pius opened this issue Oct 1, 2024 · 0 comments · Fixed by #75
Closed
10 tasks done

[ModuleCatalog] Support .spec.associatedResources #54

c-pius opened this issue Oct 1, 2024 · 0 comments · Fixed by #75
Assignees

Comments

@c-pius
Copy link
Contributor

c-pius commented Oct 1, 2024

Description

Support the associatedResources introduced via kyma-project/lifecycle-manager#1843. The module config should be extended with a new field that is than written into .spec.associatedResources.

Reasons

Support the associatedResources field introduced via kyma-project/lifecycle-manager#1843

Acceptance Criteria

  • When adding entries to module-config.yaml
    associatedResources:
    - group: networking.istio.io
      version: v1alpha3
      kind: gateways
    - group: networking.istio.io
      version: v1alpha3
      kind: virtualservices
  • Then the entry is written to the generated module template as:
    spec:
      associatedResources:
      - group: networking.istio.io
        version: v1alpha3
        kind: gateways
      - group: networking.istio.io
        version: v1alpha3
        kind: virtualservices
  • If field is not present in moduleconfig file .spec.associatedResources should be omitted
  • Validations include
    • group must be a valid group
    • version must be a valid version
    • kind must be a valid kind
  • Unit test validation
  • Adapt e2e tests
  • Add new field to scaffold command as commented field

Attachments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants